...
This led to some remarks, of which a few were "java only", but some of them reflected on the Standard in general. Items to be addressed at the next meeting:
- # Question: what does isAvailable() mean in case of multiple consumers. Do all consumers need to have the same time(s)?
- Leave in for now, review after more implementation, one suggestion of modification bool isAvailable(whosAsking);
Will be discussed later during the meeting, Stef will show an example of using isAvailable(whosAsking);
- Question: Collection or Set instead of List for (In|Out)putExchangeItems in LC?
- It will be ICollection
.
- It will be ICollection
- Question: Introduce IState instead of Object? This will emphasize the relation between IManageState and IPersistentState. Additional suggestion: IPersistentState extends IState.
(b.t.w: makePersistent / readPersistentState are wrong names, should be something like getAsByteStream)- Gena has discussed with Rob between last and current meeting. After some discussion the final result
is described on: Suggestion about changed to state management
- Gena has discussed with Rob between last and current meeting. After some discussion the final result
- To be discussed: Introduce generics in IOutputItem.Values()? i.e. weakly typed via <T>
We will not introduce generics in the standard. However, they could be used in the SDK.
- Remark: Working with providers/consumers, we should take care that such a circularity might give garbage collection problems. After a short discussion, we see no real general way so solve this risk, so it has been decided that we should leave this up to the Garbage Collector.
- Point noted, no specific agreement as to solution
We will introduce something like
OpenMIException : Exception
. However, first we will have a detailed look at the guidelines for introducing custom exceptions in both .Net and Java.
...
- Move IsAvailable to IExchangeItem. Is it only for a thread-safety? If yes than see also ICollection.IsSynchronized
Stef: The question is confusing, the actual issue is that we should distinguish between IsAvailable and IsValid.
We are now realized that there is a difference between IsAvailable (only for output item, means it is for consumers) IsValid (probably for IExchangeItem, meaning if item is valid in the context of current component, maybe updated during Validate() call)? - Move Values { get; set; } to IExchangeItem?
get; set;
to be reviewed at this meeting
When discussing get/set, the subject of the discussion graduallly moved to the pull versus loop driven approach. This led to an important decision
: We will introduce a boolean argument that indicates whether the component should run in a pull mode (like in OpenMI 1.4) or in loop mode
Wiki Markup Add *params* keyword to IArguments\[\] args parameter in Initialize(IArgument\[\] args).
- Adrian review, if happy then ...
- Adrian review, if happy then ...
- "string Validate()" / "bool IsValid(IExchangeItem item)" / "IsAvailable()", etc.
to be reviewed at this meeting
Wiki Markup (y) Add "params IOutputItem\[\] items" argument to Update() in order to specify explicitly what should be updated.
Maybe generalise to IExchangeItem i.e. allow IInputItem?
- Remove AddConsumer/RemoveConsumer and use BindingList in the implementation instead to listen to IOutputItem.Consumer.Add() / Remove()
We will leave AddConsumer/RemoveConsumer for now. The BindingList mechanism has been implemented, though, so anyone can use it
- When we get loops in the compositions - we have to tell which component will be first! In the new GUI, we will let the user indicate the 'Start up component'.
- Add Durations, TimeZone properties to ITimeSet? (see also changes from Rob in Java version)
- Replace all ITime, ITimeStamp, ITimeSpan by: System.DateTime, System.TimeSpan. Should be straightforward. For components working in Julian only time in FORTRAN CalendarConverter can be used. But for .NET all nice features of the .NET date time, time span will be available, e.g. DateTime.AddDays(int), DateTime.AddHours(int), time1 > time2, time1.AddDays(1) > DateTime.Now, and so on.
all time issues will be discussed at this meeting
- Change XYPoint+XYZPoint, ZYPolyline+XYZPolyline => Point, Polyline (make it look more like OGC entities)
- Review OGC methods to see how we know when a Z coordinate exists?
- When reviewing, also look at OGC's M-coordinate
Code Block java java ... double GetVertexMCoordinate(int elementIndex, int vertexIndex);
...
- IIdentity has been split in
IIdentifiable
andIDescribable
. Some interfaces already have been derived fromIIdentifiable
and/orIDescribable
At some stage, we should check all interfaces on whether to derive from
IIdentifiable
and/orIDescribable
or not.At this meeting, we should check that
IIdentifiable
and/orIDescribable
are not used as seperate entities.
- IArgument needs a mechanism for identifying the type of argument e.g. File, Path, int double etc Very usful for providing customised GUI functionality
- (?)Adrian to come up with proposal for next meeting
- Using empty Temporal and ElementSet in the Input items
- Changing of the ElementSet during the time and different Times (steps) for different Elements
- For the Time can be probably solved by missing values
...