Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

(plus) reviewed performance tests and decreased required time to run tests, also 30% of tests are wrong! Time is not measured or not a performance test at all. Keep quality of the tests higher.

... for example this test as a performance test is useless:

Code Block

        [Category("Performance")]
        public void ReadRegularGridPerformance()
        {
            //todo: get a bigger grid file :)
            var store = new NetCdfFunctionStore();
            store.FunctionBuilders.Add(new RegularGridCoverageBuilder());
            store.Open("../../../../data/NCEP-NAM-CONUS_80km_best.ncd.nc");
            var grid = (IRegularGridCoverage) store.Functions.First(f => f is IRegularGridCoverage);
            log.DebugFormat("Reading {0} slices of {1} values", grid.Time.Values.Count, grid.SizeX*grid.SizeY);
            DateTime start = DateTime.Now;
            foreach (DateTime dt in grid.Time.Values)
            {
                Assert.AreEqual(6045, grid.GetValues(new VariableValueFilter<DateTime>(grid.Time, dt)).Count);
            }
            log.DebugFormat("Took {0} ms", (DateTime.Now - start).TotalMilliseconds);
        }