...
5. Trying to fix solution,
TODO:
Found how to detect parent directory in DOS (awkward): "for %%a in (%PROJECT_DIR%\..) do set PLUGIN_TYPE_DIR=%%~nxa" plugin native resources should be copied fine now
Fixed many projects using ExternalDependencies (DeltaShell.proj):
| Code Block |
|---|
<ExternalDependencies>lib\DeltaShell\DeltaShell.Plugins.SharpMapGis</ExternalDependencies>
|
Fixed resource files (DeltaShell / DeltaShell - made consistent)
probably some projects should be moved from Common to default plugin level (avoid re-use by others) ...
Isolate Habitat1 dlls including Demis.MapControl (remove them, replace by dlls in lib compiled in Habitat1 branch)
Move Habitat 1 projects to branch\ and leave only required dlls in lib\Plugins\Habitat (old version)
Setup projects must be organized in accordance to plugins - IT'S A MESS NOW!!
Clean-up FitNesse tests (clean up unused tests)
REVIEW ALL TESTS DATA (too big)
1. Move data to test-data/ folder
2. Check if large data files used in integration tests can be compressed
MOVE src\Plugins\DelftModels\Externals\ds\common\packages\delft_model_data to test\ folder (not sources)
make it checkout only required C# projects on a higher level
Habitat proj file in build\ is not a good idea!!! move it to build/Plugins/Habitat.proj
Habitat inside DeltaShell\Product.wxs?!?! WTF!?!??
CommonToolsPlugin.wxs should be in DeltaShell/
DelftModels\Product.wxs is referencing ico from Habitat project!?!?!? WTF ?!@?
HabitatLogo.png in IJselmeerVerkenner ?!?? WTF?
Move OpenMI to standard DeltaShell plugins (after migration to 2.0)?
Why there is a "copy "$(SolutionDir)lib\DeltaShell\DeltaShell.Gui\license.lic" .\" in DeltaShell.Loader.csproj ?!? Sobek?
Make SharpMapTestUtils and DelftTools.TestUtils consistent (chose one convention)
INTRODUCE RULE: if you include project on a file system - it must be available in the solution, otherwise remove it from the file system as well!
ONE MORE RULE - NO HIDDEN FILES in projects!
NetTopologySuite.Extensions referencing NHibernate.dll WTF?!?
move lib\DeltaShell\DeltaShell.Plugins.SharpMapGis\ to lib\Common\SharpMap.Extensions?
The following projects need to be included into the solution (migrated) or deleted:
src\Plugins\Examples\DeltaShell.AutomationDemo
src\Plugins\Examples\DeltaShell.Plugins.TriangulatorPlugin
test\Plugins\Examples\DeltaShell.Plugins.DemoImportPlugin.Test
test\Plugins\Examples\DeltaShell.Plugins.TriangulatorPlugin.Tests
test\Plugins\Habitat\TransformOldCases
test\Plugins\Habitat\Habitat.Tests
DeltaShell.Plugins.SharpMapGis.csproj references NHibernate.dll - remove it!?
DeltaShell.Plugins.Series.csproj references NHibernate.dll
write test checking number of csproj in solution and on file system (should match 
)
walk through ALL projects and remove PLUGIN -> PLUGIN dependencies!
WTF, why SharpMapGis plugin references DeltaShell.Core???
FIX ALL NAMESPACES
Loader is referencing Common projects so that they will be copied to Loader/bin/ - discuss!
FIX images, some are DeltaShell.* and also not used
REMOVE / MOVE TO OLD CODE DeltaShell.Plugins.Demis.MapControl ??? (not used in the current solution)
I had to comment some code to make everything work, check diff on revision when new-layout branch was created
Strange that it was necessary to re-reference NetTopologySuite, do we have it as DLL somewhere??
REMOVE reference to DeltaShell.Plugins.SharpMapGis in SharpMap.UI.Tests!
make SharpMap.Extensions.Xml work (current excluded), migrate from plugin (pull-up)
search all project for DelftShell and fix it (some dirs, files need to be renamed)
check ALL hidded files not included into project and clean-up!
Rename DeltaShell.Plugins.KRWVerkenner in source code tree to something more intuitive for all users (including non-Dutch), e.g.: DeltaShell.Plugins.BasinModels (basin management), move it into DelftModels
...
NetworkEditor is a HydroNetworkEditor, right? Maybe we need Hydro plugin containing various edtors (Basin, HydroNetwork, etc.)
Strange properties in DeltaShell.Loader resources, e.g.: "DelftShellFolderFileFilter: Delta Shell Folder File (.folder)|*.folder" - check where they are used and remove