You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 4 Next »

Functional : Does it work?
Are the requirements clear from
Does the code execute as expected? (Does is meet the requirement of the issue/task)
Are resources, events and memory released in all paths? (Disposable called?)

Tests : Is it tested?
Is there a unit test?
Is there a valid integration-test (DataAccess,Integration or Performance)?

Design : Is the code maintainable?
Do you understand the code you are reviewing?
Are user interface, business logic and IO separated?
Is the code change limited to the requested issue/task?
Is it easy to maintain (simple,robust,DRY,implementation hiding)?
Does the code not duplicatie existing functionality ? (Don't reinvent the wheel)
Does the code follow (DS) naming conventions? (variable names,test class names etc,FXCop?)

Documentation Is it (self)documented?
Are all functions, methods and classes documented? (Summary,parameters,comments etc)

  • No labels